-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Handling controller and LoadPolicies #5241
Merged
robwalch
merged 11 commits into
master
from
feature/error-controller-pathway-penalty-network-policy
Feb 27, 2023
Merged
Error Handling controller and LoadPolicies #5241
robwalch
merged 11 commits into
master
from
feature/error-controller-pathway-penalty-network-policy
Feb 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
feature/error-controller-pathway-penalty-network-policy
branch
from
February 18, 2023 20:18
e49ff5c
to
1116105
Compare
robwalch
force-pushed
the
feature/error-controller-pathway-penalty-network-policy
branch
4 times, most recently
from
February 22, 2023 01:08
8d1b80e
to
bba791b
Compare
Add Error Handling Integration Tests Handle missed probe transmux probe with with FRAG_PARSING_ERROR Handle encrypted init segment and subtitle decryption failure with FRAG_DECRYPT_ERROR Remove delay when retrying after timeout Trigger FRAG_LOADING after request is made ERROR event data type must include an error property Add stats to network loader error callbacks to allow error handling to use request timing Remove use of console.warn from mp4-tools Add missing TypeScript type exports
…t.errorRetry.maxNumRetry (6) times Fixes #5011
…t.errorRetry.maxNumRetry (6) times 2/2 Fixes #5011
Warn on currentFrag context reference change and use currentFrag to maintain correct stats ref Fixes #5230
robwalch
force-pushed
the
feature/error-controller-pathway-penalty-network-policy
branch
from
February 22, 2023 03:02
bba791b
to
024db11
Compare
This was referenced Feb 22, 2023
robwalch
commented
Feb 23, 2023
robwalch
commented
Feb 24, 2023
robwalch
force-pushed
the
feature/error-controller-pathway-penalty-network-policy
branch
from
February 24, 2023 21:39
33224cf
to
d23e53a
Compare
Cleanup frag stats handoff
…izes retry on parse errors)
robwalch
force-pushed
the
feature/error-controller-pathway-penalty-network-policy
branch
from
February 25, 2023 00:14
d23e53a
to
90984f9
Compare
…ch when no alternate is available
robwalch
force-pushed
the
feature/error-controller-pathway-penalty-network-policy
branch
from
February 25, 2023 03:32
e629562
to
981875c
Compare
robwalch
deleted the
feature/error-controller-pathway-penalty-network-policy
branch
February 27, 2023 19:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Implement an ErrorController to handle error events before and after other controllers. On ERROR, ErrorController is responsible for level switching, falling back to redundant streams, and escalating errors to
fatal
when there is no action to take.Why is this Pull Request needed?
Improve error handling and consolidate error handling logic so that it is easier to follow, and so that it can be replaced with a custom controller.
Completes Content Steering by implementing Pathway penalty and switching on error.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
stopLoad()
and then restarting withstartLoad()
causes a transition to the lowest level #5230Checklist