Fix error handling for GAP tags in subtitles or audio #6478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith no alternate Related to #6475
5 tasks
robwalch
added a commit
that referenced
this pull request
Jun 4, 2024
* patch/v1.5.x: Fix error handling for GAP tags in subtitles or audio (#6478)
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix default error handling of GAP tags always treated as error in MAIN playlist.
Why is this Pull Request needed?
getLevelSwitchActionignores candidates with the same group ID, but this was being short-circuited by theerrorDetails === ErrorDetails.FRAG_GAP && data.fragcheck.Are there any points in the code the reviewer needs to double check?
Adding the subtitle fragment with a gap to the fragment tracker prevents loop loading with repeated gap tag error events.
Resolves issues:
Resolves #6475
Checklist