do not add dash playlists to resources

videojs · Jul 18, 2019 · 8f73d2b · 8f73d2b
1 parent 9f8ffa3
commit 8f73d2b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/walk-manifest.js b/src/walk-manifest.js
@@ -223,12 +223,12 @@ const walkPlaylist = function(options) {
         return onError(manifestError, manifest.uri, resources, resolve, reject);
       }
       // Only push manifest uris that get a non 200 and don't timeout
-      resources.push(manifest);
-      visitedUrls.push(manifest.uri);
-
       let dash;
 
       if (!dashPlaylist) {
+        resources.push(manifest);
+        visitedUrls.push(manifest.uri);
+
         manifest.content = response.body;
         if ((/^application\/dash\+xml/i).test(response.headers['content-type']) || (/^\<\?xml/i).test(response.body)) {
           dash = true;

diff --git a/test/unit/walk-manifest.spec.js b/test/unit/walk-manifest.spec.js
@@ -610,11 +610,8 @@ describe('walk-manifest', function() {
           const setResources = new Set(resources);
           const count = {mp4: 0, m4v: 0, m4a: 0, mpd: 0};
 
-          assert.equal(setResources.size, 44);
+          assert.equal(setResources.size, 37);
           setResources.forEach(function(item) {
-            if (!item.uri) {
-              return;
-            }
             if (item.uri.includes('.mp4')) {
               count.mp4 += 1;
             } else if (item.uri.includes('.m4v')) {