Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix coverage ci #1135

Merged
merged 4 commits into from
May 27, 2021
Merged

chore: fix coverage ci #1135

merged 4 commits into from
May 27, 2021

Conversation

brandonocasey
Copy link
Contributor

seems like coverage is failing on ci right now, trying to fix it.

gkatsev
gkatsev previously approved these changes May 27, 2021
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #1135 (78bad70) into main (1c7a63b) will increase coverage by 0.17%.
The diff coverage is 93.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1135      +/-   ##
==========================================
+ Coverage   86.20%   86.38%   +0.17%     
==========================================
  Files          39       39              
  Lines        9289     9435     +146     
  Branches     2127     2174      +47     
==========================================
+ Hits         8008     8150     +142     
- Misses       1281     1285       +4     
Impacted Files Coverage Δ
src/manifest.js 93.00% <28.57%> (-4.85%) ⬇️
src/playlist.js 94.11% <89.74%> (-0.39%) ⬇️
src/playlist-loader.js 93.10% <91.11%> (+1.46%) ⬆️
src/media-segment-request.js 95.72% <98.52%> (+0.99%) ⬆️
src/segment-loader.js 96.08% <100.00%> (+0.26%) ⬆️
src/sync-controller.js 96.89% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4449ed5...78bad70. Read the comment docs.

gkatsev
gkatsev previously approved these changes May 27, 2021
@brandonocasey brandonocasey merged commit 82b6781 into main May 27, 2021
@brandonocasey brandonocasey deleted the fix/coverage branch May 27, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants