Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: streaming events and errors #1508

Merged
merged 14 commits into from
May 16, 2024
Merged

feat: streaming events and errors #1508

merged 14 commits into from
May 16, 2024

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented May 5, 2024

Description

Adding some additional events and errors with relevant payloads to VHS to enable users to centralize streaming events and utilize the information passed with each error and event payload to inform their video playback code.

Specific Changes proposed

Add events and payloads for all phases of playback from manifest/playlist request - load - parse. Segment load - transmux/parse/decrypt - append. Errors and relevant payloads for common network, segment and playlist/manifest conditions.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 88.68778% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 86.31%. Comparing base (b6ff608) to head (a14d0e6).

Files Patch % Lines
src/dash-playlist-loader.js 80.76% 5 Missing ⚠️
src/media-segment-request.js 87.17% 5 Missing ⚠️
src/source-updater.js 37.50% 5 Missing ⚠️
src/content-steering-controller.js 77.77% 2 Missing ⚠️
src/playlist-loader.js 93.10% 2 Missing ⚠️
src/segment-loader.js 94.73% 2 Missing ⚠️
src/segment-transmuxer.js 60.00% 2 Missing ⚠️
src/playlist-controller.js 95.23% 1 Missing ⚠️
src/videojs-http-streaming.js 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1508      +/-   ##
==========================================
+ Coverage   86.29%   86.31%   +0.01%     
==========================================
  Files          43       43              
  Lines       10901    11098     +197     
  Branches     2508     2532      +24     
==========================================
+ Hits         9407     9579     +172     
- Misses       1494     1519      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrums86 adrums86 marked this pull request as ready for review May 13, 2024 05:46
src/segment-loader.js Outdated Show resolved Hide resolved
@adrums86 adrums86 merged commit c94a230 into main May 16, 2024
15 checks passed
@adrums86 adrums86 deleted the streaming-events-errors branch May 16, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants