fix: add native cues when using native text tracks

[third774]

Co-authored-by: Kyle Boutette kyleveb@gmail.com

Description

When native text tracks are used, the cues added need to be native cues.

Related to this PR in the player: videojs/video.js#6410

Specific Changes proposed

Checks to see if native tracks are being used, and if so converts the cue into a native cue.

Requirements Checklist

• Feature implemented / Bug fixed
• If necessary, more likely in a feature request than a bug fix
  • Unit Tests updated or fixed
  • Docs/guides updated
  • Example created (starter template on JSBin)
• Reviewed by Two Core Contributors

[welcome]

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

• Run npm run lint -- --errors locally to catch formatting errors earlier.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[third774]

Not sure how best to go about creating an example with this fix implemented. It's also dependent on the related PR in the player.

[third774]

Additionally, not sure what adding tests for this would look like. With a little guidance I'd be happy to take a stab at it! 😄

[third774]

Here's a demo of native captions working with this change!

The video.js file in this demo was built with video.js on commit ff9fd1c which is the related PR videojs/video.js#6410 and having linked the @videojs/http-streaming dep to this PR's commit 86dfba9

https://third774.github.io/videojs-native-captions-fix/

[gkatsev]

Thanks @third774, we'll take a look soon.

[third774]

Looks like this breaks a few tests... looking into this now.

[third774]

Added a test for this as well!

[third774]

Just wanted to circle back around on this — is there anything else blocking this change (and related PR videojs/video.js#6410) from being merged?

[gkatsev]

@third774 hey, thanks for your patience! We'll take a look in the next day or so.

[gkatsev]

Closing this in favor of #759, I rebased it and has a tiny change in the test. I'll merge it manually to maintain authorship credit once it's reviewed.