fix: add dispose functions and fix memory leaks #643 for 1.x

src/dash-playlist-loader.js

@@ -230,11 +230,14 @@ export default class DashPlaylistLoader extends EventTarget {
   }
 
   dispose() {
+    this.trigger('dispose');
     this.stopRequest();
     this.loadedPlaylists_ = {};
     window.clearTimeout(this.minimumUpdatePeriodTimeout_);
     window.clearTimeout(this.mediaRequest_);
     window.clearTimeout(this.mediaUpdateTimeout);
+
+    this.off();
   }
 
   hasPendingRequest() {

src/master-playlist-controller.js

@@ -1037,6 +1037,7 @@ export class MasterPlaylistController extends videojs.EventTarget {
    * that it controls
    */
   dispose() {
+    this.trigger('dispose');
     this.decrypter_.terminate();
     this.masterPlaylistLoader_.dispose();
     this.mainSegmentLoader_.dispose();
@@ -1055,6 +1056,11 @@ export class MasterPlaylistController extends videojs.EventTarget {
 
     this.audioSegmentLoader_.dispose();
     this.subtitleSegmentLoader_.dispose();
+    this.off();
+
+    if (this.mediaSource.dispose) {
+      this.mediaSource.dispose();
+    }
   }
 
   /**

src/mse/html-media-source.js

@@ -340,4 +340,17 @@ export default class HtmlMediaSource extends videojs.EventTarget {
     this.sourceBuffers.push(buffer);
     return buffer;
   }
+
+  dispose() {
+    this.trigger('dispose');
+    this.off();
+
+    this.sourceBuffers.forEach(function(buffer) {
+      if (buffer.dispose) {
+        buffer.dispose();
+      }
+    });
+
+    this.sourceBuffers.length = 0;
+  }
 }

src/mse/virtual-source-buffer.js

@@ -600,4 +600,9 @@ export default class VirtualSourceBuffer extends videojs.EventTarget {
     this.pendingBuffers_.length = 0;
     this.bufferUpdating_ = false;
   }
+
+  dispose() {
+    this.trigger('dispose');
+    this.off();
+  }
 }

src/playlist-loader.js

@@ -329,9 +329,11 @@ export default class PlaylistLoader extends EventTarget {
     * Abort any outstanding work and clean up.
     */
   dispose() {
+    this.trigger('dispose');
     this.stopRequest();
     window.clearTimeout(this.mediaUpdateTimeout);
     window.clearTimeout(this.finalRenditionTimeout);
+    this.off();
   }
 
   stopRequest() {

src/segment-loader.js

@@ -206,7 +206,8 @@ export default class SegmentLoader extends videojs.EventTarget {
       time: 0
     };
 
-    this.syncController_.on('syncinfoupdate', () => this.trigger('syncinfoupdate'));
+    this.triggerSyncInfoUpdate_ = () => this.trigger('syncinfoupdate')
+    this.syncController_.on('syncinfoupdate', this.triggerSyncInfoUpdate_);
 
     this.mediaSource_.addEventListener('sourceopen', () => this.ended_ = false);
 
@@ -247,6 +248,7 @@ export default class SegmentLoader extends videojs.EventTarget {
    * dispose of the SegmentLoader and reset to the default state
    */
   dispose() {
+    this.trigger('dispose');
     this.state = 'DISPOSED';
     this.pause();
     this.abort_();
@@ -257,6 +259,16 @@ export default class SegmentLoader extends videojs.EventTarget {
     if (this.captionParser_) {
       this.captionParser_.reset();
     }
+
+    if (this.checkBufferTimeout_) {
+      window.clearTimeout(this.checkBufferTimeout_);
+    }
+
+    if (this.syncController_ && this.triggerSyncInfoUpdate_) {
+      this.syncController_.off('syncinfoupdate', this.triggerSyncInfoUpdate_);
+    }
+
+    this.off();
   }
 
   /**

src/sync-controller.js

@@ -586,4 +586,9 @@ export default class SyncController extends videojs.EventTarget {
       }
     }
   }
+
+  dispose() {
+    this.trigger('dispose');
+    this.off();
+  }
 }