fix: Use revokeObjectURL dispose for created MSE blob urls #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
May 21, 2020
gkatsev
reviewed
May 21, 2020
| @@ -829,6 +831,11 @@ class HlsHandler extends Component { | |||
| delete this.tech_.hls; | |||
| } | |||
|
|
|||
| if (this.mediaSourceUrl_ && window.URL.revokeObjectURL) { | |||
| window.URL.revokeObjectURL(this.mediaSourceUrl_); | |||
There was a problem hiding this comment.
Alternatively, we could've gotten the blob url via this.tech_.src() but I think this is fine as well.
|
Added a test. 🤞 for ie 11... |
gesinger
previously approved these changes
May 21, 2020
gkatsev
previously approved these changes
Jun 12, 2020
brandonocasey
force-pushed
the
fix/revoke-mse-urls
branch
from
7a5827e
to
daf4274
Compare
gkatsev
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a memory leak that we have right now, caused by not revoking urls that we create.