chore(demo): add a representations selector to the demo page #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Jul 13, 2020
| @@ -277,10 +327,15 @@ | |||
| } else { | |||
| sources.dispatchEvent(newEvent('change')); | |||
| } | |||
| player.on('loadedmetadata', () => { | |||
| player.on('loadedmetadata', function() { | |||
There was a problem hiding this comment.
As you can guess, ie 11 didn't like this
brandonocasey
commented
Jul 13, 2020
| @@ -165,6 +185,36 @@ | |||
| onload(); | |||
| }; | |||
|
|
|||
| var regenerateRepresentations = function() { | |||
| while (representationsEl.firstChild) { | |||
There was a problem hiding this comment.
As things are blacklisted representations can be removed/added.
brandonocasey
commented
Jul 13, 2020
| representationsEl.appendChild(option); | ||
| }); | ||
|
|
||
| representationsEl.selectedIndex = selectedIndex; |
There was a problem hiding this comment.
This does not trigger a change event on representationsEl as that only happens when not using the js api.
|
slowly we're adding stats page features |
|
haha yep |
gkatsev
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While looking into issues related to codec switching and representation/playlist changes I implemented local changes to select representations using the demo ui. I think this would benefit all of us, so I cleaned it up and wrapped it into a pull request.