fix unhandled exception #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc captions may not have any values, for example if language is unknown value may be omitted. TypeError: Cannot read property 'split' of undefined <Accessibility schemeIdUri="urn:scte:dash:cc:cea-608:2015"></Accessibility>
|
I could've sworn I tested it, but looking at the tests I added in the initial PR, I don't have any where the value is missing. #131 |
Codecov Report
@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 17 17
Lines 657 657
Branches 212 214 +2
=======================================
Hits 610 610
Misses 47 47
Continue to review full report at Codecov.
|
gkatsev
approved these changes
Oct 6, 2021
|
Also, I would recommend updating your manifests to include a value. The spec (ANSI_SCTE 214-1 2016) highly recommends including a value, even if it allows not having one. |
gesinger
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc captions may not have any values, for example if language is unknown value may be omitted.
TypeError: Cannot read property 'split' of undefined