add support for SegmentTemplate padding format string and SegmentTimeline #16
Conversation
|
Could you add jsdocs for the new functions? We'll get to the other functions later |
mjneil
force-pushed
the
feat/template-padding
branch
from
4a71905
to
6049dbf
Compare
src/segmentTemplate.js
Outdated
| * Value of the Representation@bandwidth attribute. | ||
| * @param {number} values.Time | ||
| * Timestamp value of the corresponding segment | ||
| * @return {(match: string, identifier: string, format: string, width: string) => string} |
There was a problem hiding this comment.
Following this format jsdoc/jsdoc#1286 (comment)
Our linter isn't too happy with it warning JSDoc syntax error valid-jsdoc. Not sure of a better way of expressing this. It won't prevent builds from passing at least
| if (segmentTime && segmentTime > time) { | ||
| // discontinuity | ||
|
|
||
| // TODO: How to handle this type of discontinuity |
There was a problem hiding this comment.
any thoughts on this TODO @forbesjo @gesinger ?
relevant spec text 5.3.9.6
the signalling of discontinuities of the Media Presentation timeline for which no Segment data are present in a specific Representation.
If the value of the attribute is greater than what is expressed by the previous S element, it expresses discontinuities in the timeline.
I also found this blog post that mentioned the discontinuities briefly http://www.unified-streaming.com/blog/stop-numbering-underappreciated-power-dashs-segmenttimeline
Based on the wording of the spec and that blog post, this form of discontinuity signaling appears to be the DASH equivalent of EXT-X-GAP
There was a problem hiding this comment.
Talked about this in chat, we'll leave this as is.
This adds support for the following SegmentTemplate features