fix: reset() should null check the controlBar (#7692)

Fixes #7689 Co-authored-by: alex <try2betheb3st@gmail.com> Co-authored-by: Pat O'Neill <pgoneill@gmail.com>
videojs · May 4, 2022 · 7e2b9ec · 7e2b9ec
1 parent 0543298
commit 7e2b9ec
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/js/player.js b/src/js/player.js
@@ -3605,7 +3605,7 @@ class Player extends Component {
   resetProgressBar_() {
     this.currentTime(0);
 
-    const { durationDisplay, remainingTimeDisplay } = this.controlBar;
+    const { durationDisplay, remainingTimeDisplay } = this.controlBar || {};
 
     if (durationDisplay) {
       durationDisplay.updateContent();

diff --git a/test/unit/player.test.js b/test/unit/player.test.js
@@ -2066,6 +2066,24 @@ QUnit.test('player#reset removes remote text tracks', function(assert) {
   log.warn.restore();
 });
 
+QUnit.test('player#reset progress bar', function(assert) {
+
+  let error;
+
+  const player = TestHelpers.makePlayer();
+
+  player.removeChild('controlBar');
+  player.controlBar = null;
+
+  try {
+    player.resetProgressBar_();
+  } catch (e) {
+    error = e;
+  }
+
+  assert.notOk(error, 'Function did not throw an error on resetProgressBar');
+});
+
 QUnit.test('Remove waiting class after tech waiting when timeupdate shows a time change', function(assert) {
   const player = TestHelpers.makePlayer();