Minor modifications to #627

videojs · Aug 26, 2013 · acb4a43 · acb4a43
1 parent 75dd7c5
commit acb4a43
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/js/lib.js b/src/js/lib.js
@@ -461,7 +461,7 @@ vjs.formatTime = function(seconds, guide) {
       gh = Math.floor(guide / 3600);
 
   // handle invalid times
-  if (window['isNaN'](seconds) || seconds === Infinity) {
+  if (isNaN(seconds) || seconds === Infinity) {
     // '-' is false for all relational operators (e.g. <, >=) so this setting
     // will add the minimum number of fields specified by the guide
     h = m = s = '-';

diff --git a/test/unit/lib.js b/test/unit/lib.js
@@ -197,6 +197,7 @@ test('should format time as a string', function(){
 test('should format invalid times as dashes', function(){
   equal(vjs.formatTime(Infinity, 90), '-:-');
   equal(vjs.formatTime(NaN), '-:-');
+  // equal(vjs.formatTime(NaN, 216000), '-:--:--');
   equal(vjs.formatTime(10, Infinity), '0:00:10');
   equal(vjs.formatTime(90, NaN), '1:30');
 });