Skip to content

Commit

Permalink
@misteroneill fixed npm test from running coveralls locally. closes #…
Browse files Browse the repository at this point in the history
  • Loading branch information
misteroneill authored and gkatsev committed Jul 21, 2016
1 parent 5b15feb commit b270f58
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ CHANGELOG
* @OwenEdwards removed spurious head tags in the simple-embed example ([view](https://github.com/videojs/video.js/pull/3438))
* @ntadej added a null check to errorDisplay usage ([view](https://github.com/videojs/video.js/pull/3440))
* @misteroneill fixed logging issues on IE by separating fn.apply and stringify checks ([view](https://github.com/videojs/video.js/pull/3444))
* @misteroneill fixed npm test from running coveralls locally ([view](https://github.com/videojs/video.js/pull/3449))

--------------------

Expand Down
3 changes: 2 additions & 1 deletion build/grunt.js
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,8 @@ module.exports = function(grunt) {
// Default task - build and test
grunt.registerTask('default', ['test']);

grunt.registerTask('test', ['build', 'karma:defaults']);
// The test script includes coveralls only when the TRAVIS env var is set.
grunt.registerTask('test', ['build', 'karma:defaults'].concat(process.env.TRAVIS && 'coveralls').filter(Boolean));

// Run while developing
grunt.registerTask('dev', ['build', 'connect:dev', 'concurrent:watchSandbox']);
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"homepage": "http://videojs.com",
"author": "Steve Heffernan",
"scripts": {
"test": "grunt test && if [ '$TRAVIS' ]; then grunt coveralls; fi;"
"test": "grunt test"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit b270f58

Please sign in to comment.