Skip to content

Commit

Permalink
@mmcc added ES6 default args and template strings. closes #2015
Browse files Browse the repository at this point in the history
  • Loading branch information
mmcc authored and heff committed Apr 22, 2015
1 parent a02ee27 commit e1e6994
Show file tree
Hide file tree
Showing 50 changed files with 353 additions and 385 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: node_js
node_js:
- 0.10
- "iojs"
before_script:
- if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then curl https://gist.githubusercontent.com/santiycr/5139565/raw/sauce_connect_setup.sh | bash; fi
before_install:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ CHANGELOG
* @dn5 Added new translations (Bosnian, Serbian, Croatian) ([view](https://github.com/videojs/video.js/pull/1897))
* @mmcc (and others) converted the whole project to use ES6, Babel and Browserify ([view](https://github.com/videojs/video.js/pull/1976))
* @heff converted all classes to use ES6 classes ([view](https://github.com/videojs/video.js/pull/1993))
* @mmcc added ES6 default args and template strings ([view](https://github.com/videojs/video.js/pull/2015))

--------------------

Expand Down
2 changes: 1 addition & 1 deletion src/js/big-play-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Button from './button';
/**
* Initial play button. Shows before the video has played. The hiding of the
* big play button is done via CSS and player states.
* @param {vjs.Player|Object} player
* @param {Player|Object} player
* @param {Object=} options
* @class
* @constructor
Expand Down
4 changes: 2 additions & 2 deletions src/js/button.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import document from 'global/document';
================================================================================ */
/**
* Base class for all buttons
* @param {vjs.Player|Object} player
* @param {Player|Object} player
* @param {Object=} options
* @class
* @constructor
Expand Down Expand Up @@ -56,7 +56,7 @@ class Button extends Component {

buildCSSClass() {
// TODO: Change vjs-control to vjs-button?
return 'vjs-control ' + super.buildCSSClass();
return `vjs-control ${super.buildCSSClass()}`;
}

// Click - Override with specific functionality for button
Expand Down
Loading

0 comments on commit e1e6994

Please sign in to comment.