Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manualtimeupdates should be turned on before triggering player ready #1414

Closed
dmlap opened this issue Aug 13, 2014 · 1 comment
Closed

Manualtimeupdates should be turned on before triggering player ready #1414

dmlap opened this issue Aug 13, 2014 · 1 comment

Comments

@dmlap
Copy link
Member

dmlap commented Aug 13, 2014

If you're trying to start the player with a tech that requires manual timeupdate events as soon as the tech is ready, the initial play event will be missed and timeupdate events will not fire. For instance:

// this callback will be invoked *before* the handlers for manualtimeupdates are 
// registered
player.ready(function() {
  player.play();
});

// playback begins but anything that relies on timeupdates is broken

I'd suggest moving the triggerReady() invocation below the registration of manual progress and timeupdate listeners.

@dmlap
Copy link
Member Author

dmlap commented Aug 13, 2014

This issue may be related to #1407.

dmlap added a commit to dmlap/video.js that referenced this issue Aug 13, 2014
Migrate the timers that manage creating timeupdate and progress events when the tech doesn't support them natively. Now, techs that extend MediaTechController will continue to automatically pick up synthetic playback and buffering events but they're scoped much more closely to the entity that needs them. In addition, time and progress tracking have been moved much earlier into the component initialization which fixes videojs#1414.
@dmlap dmlap closed this as completed in f4ce62d Aug 14, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant