Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'webkitMovementX' is deprecated in Google Chrome #2548

Closed
marina9568 opened this issue Sep 3, 2015 · 4 comments
Closed

'webkitMovementX' is deprecated in Google Chrome #2548

marina9568 opened this issue Sep 3, 2015 · 4 comments
Labels
confirmed enhancement

Comments

@marina9568
Copy link

Good day.

After Google Chrome upgrade I get this notices in console:
'webkitMovementX' is deprecated. Please use 'movementX' instead. (video.dev.js:503)
'webkitMovementY' is deprecated. Please use 'movementY' instead. (video.dev.js:503)
In Firefox no such problem.

Thank you,
Marina.
@moay
Copy link

moay commented Sep 3, 2015

Got that, too. Doesn't change a thing for now...

@heff
Copy link
Member

heff commented Sep 3, 2015

We don't actually use it, it just gets copied as part of our event process because the key still exists. We need to add it to the other deprecated keys, if anyone wants to make a PR for it.
https://github.com/videojs/video.js/blob/master/src/js/utils/events.js#L239

@forbesjo
Copy link
Contributor

forbesjo commented Sep 4, 2015

I'll open PRs for master and stable.

forbesjo pushed a commit to forbesjo/video.js that referenced this issue Sep 4, 2015
Skip copying webkitMovementX/Y
9a17c17 
webkitMovementX/Y seem to be deprecated in Chrome 45+, this fix skips
those keys.
Fixes videojs#2548
@forbesjo forbesjo mentioned this issue Sep 4, 2015
Closed
@heff
Copy link
Member

heff commented Sep 10, 2015

Fixed in master and stable

@heff heff closed this as completed Sep 10, 2015
@SourceCode SourceCode mentioned this issue Feb 13, 2016
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
confirmed enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip copying webkitMovementX/Y forbesjo/video.js
4 participants
@heff @moay @forbesjo @marina9568