Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uglify does not work #3707

Closed
doublex opened this issue Oct 24, 2016 · 5 comments
Closed

Uglify does not work #3707

doublex opened this issue Oct 24, 2016 · 5 comments

Comments

@doublex
Copy link

doublex commented Oct 24, 2016

CDN is fine, but the "video.min.js" from "video-js-5.11.7.zip" and newer is not properly minified:
filesize 5.11.6: 281 kb
filesize 5.11.7+: 494 kb
@gkatsev
Copy link
Member

gkatsev commented Oct 24, 2016

Looking at it, it's minifying it just fine but for some reason comments are still preserved.

@gkatsev
Copy link
Member

gkatsev commented Oct 24, 2016

Looks like what preserveComments does in uglify changed.

gkatsev added a commit that referenced this issue Oct 24, 2016
@gkatsev
fix: remove unnecessary comments from video.min.js
bbacaad 
This involves updating to latest version of uglify and setting
"screwIE8" to false since that is a default in 2.7. However, this makes
"preserveComments" "some" work as it is supposed to work.

Fixes #3707
@gkatsev gkatsev mentioned this issue Oct 24, 2016
Merged
@gkatsev
Copy link
Member

gkatsev commented Oct 24, 2016

Potential fix: #3709

gkatsev added a commit that referenced this issue Oct 24, 2016
@gkatsev
fix: remove unnecessary comments from video.min.js (#3709)
9695613 
This involves updating to latest version of uglify and setting
"screwIE8" to false since that is a default in 2.7. However, this makes
"preserveComments" "some" work as it is supposed to work.

Fixes #3707
@gkatsev
Copy link
Member

gkatsev commented Oct 24, 2016

Fixed by #3709.

@gkatsev gkatsev closed this as completed Oct 24, 2016
@gkatsev
Copy link
Member

gkatsev commented Oct 25, 2016

Fixed in 5.11.9.

gkatsev added a commit to gkatsev/video.js that referenced this issue Oct 25, 2016
@gkatsev
fix: remove unnecessary comments from video.min.js (videojs#3709)
fe760a4 
This involves updating to latest version of uglify and setting
"screwIE8" to false since that is a default in 2.7. However, this makes
"preserveComments" "some" work as it is supposed to work.

Fixes videojs#3707. This also comes from the stable branch after the 5.11.9
release.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doublex @gkatsev