Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silvermine Chromecast plugin doesn't work in v7.7.0 #6328

Closed
DJ-PD opened this issue Nov 22, 2019 · 3 comments · Fixed by #6329
Closed

Silvermine Chromecast plugin doesn't work in v7.7.0 #6328

DJ-PD opened this issue Nov 22, 2019 · 3 comments · Fixed by #6329

Comments

@DJ-PD
Copy link

DJ-PD commented Nov 22, 2019

Description

Silvermine Chromecast plugin doesn't work in v7.7.0.
https://codepen.io/DJ-PD/pen/jdWWEg

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. Under settings/html/head replace v7.6.6 to v7.7.0 both script and css ***SCRiPTS***/ ***STYLESHEETS***
  2. Test with above codepen e.g test 7
  3. Chromecast icon disappear

Results

Expected

Chromecast icon present and function works.

Actual

Chromecast icon disappear.

Error output

n/a

Additional Information

Will share this information with Silvermine Chromecast plugin team as well.

versions

videojs

7.6.x and 7.7.0

browsers

Chrome version 78.0.3904.108 and probably more.

OSes

Windows 10, Android, iOS

plugins

Silvermine chromecast

@welcome
Copy link

welcome bot commented Nov 22, 2019

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@gkatsev
Copy link
Member

gkatsev commented Nov 22, 2019

Thanks, looking like it broke when we were moving things around to reduce file size.

@gkatsev
Copy link
Member

gkatsev commented Nov 22, 2019

I can confirm that it is working again with 7.7.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants