Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress control UI is not updating correctly on seek of paused video #6370

Closed
onerzafer opened this issue Dec 23, 2019 · 3 comments
Closed

Comments

@onerzafer
Copy link

Description

Progress control is not updating as expected when the video is paused and the user would like to seek a point in time by clicking the progress bar.
reduced test case

Steps to reproduce

  1. Open the reduced test case
  2. play the video
  3. pause the video
  4. wait until video fully loaded
  5. click to the progress bar to seek the video for a different time
  6. observe the progress bar and progress bar handle is not moving to the clicked point.
  7. play the video and observe the UI update correctly and video actually play from where the user clicks

Results

Expected

Regardless of the video is paused or not the user should be able to see an update from the UI.

Actual

On a paused video clicking the progress bar correctly updates the vide but not the progress bar.

Error output

There is no js error only UI is behaving oddly.

Additional Information

versions

videojs

video.js 7.7.1

browsers

Tested on Chrome

OSes

Tested on Mac Catalina 10.15.1

plugins

no plugins used

@welcome
Copy link

welcome bot commented Dec 23, 2019

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@gkatsev
Copy link
Member

gkatsev commented Dec 23, 2019

Thanks, it's something that we got an issue for previously but accidentally got closed #6232. They also opened a PR but the fix is a bit trickier than expected #6234.

@gkatsev
Copy link
Member

gkatsev commented Dec 23, 2019

Going to close this as a duplicate of those two. Thanks for writing up a detailed report.

@gkatsev gkatsev closed this as completed Dec 23, 2019
gkatsev pushed a commit that referenced this issue Dec 24, 2019
When we are paused, call update directly, otherwise, call the throttled update.

Fixes #6232, fixes #6234, fixes #6370.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants