-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalization (i18n) support #663
Comments
No solution for internationalization yet. It probably wouldn't be too hard to pull out all the english text into variables that can be overridden in vjs.options, if you want to make a try at it. |
Updated description and confirming as an enhancement. |
@heff, @seniorflexdeveloper and I did some thinking about how to add this capability to video.js and make it relatively easy for plugins to piggy-back their custom messages into the framework. The solution we're proposing has three parts:
This won't support switching languages at runtime but it should mean that video.js + support for one language has the same runtime cost (download size, text rendering) as the current distribution does. I captured some of the discussion in a gist that may or may not be comprehensible. @seniorflexdeveloper volunteered to take a stab at it and open a PR. |
I'm willing to translate the strings in French when a localization system is done. Couldn't it just be something like -original EN file:
-Translated file:
That's what I use combined with i18n. Easy and really light |
I could offer an Italian and German translation :) i also would need the translation method for a plugin im currently writing! |
@philipgiuliani that would be awesome. |
@heff would this be considered finished? Not sure what is left for this. |
I will take a look tomorrow. Is there already an API to use it in custom plugins? |
@philipgiuliani - The link @gkatsev referred to is out of date. There is a new implementation using a custom grunt plugin. A better example of this would be to review our errors plugin at https://github.com/brightcove/videojs-errors/, which uses the current way. |
Cool solution :) Thanks for your help! @gkatsev @seniorflexdeveloper |
Sounds like we're all good here? I'm going to go ahead and close this one, but feel free to yell at me if I'm wrong and I'll reopen. @philipgiuliani looking forward to the Italian and German translations! |
Support replacing all english strings (captions menus, ARIA, etc.) with other languages.
The first step will be to store all english strings in variables.
We should also store all the language translations in a separate plugin so they don't add a ton of weight to the player.
ORIGINAL MESSAGE
Subject: Translating??
Hello.
I am french and the player isn't french, well i've tried to navigate over the code I wanted to translate like the "captions off" text to french.
And they seem to be no solutions.
Anybody has one?
The text was updated successfully, but these errors were encountered: