Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not compatible with latest version of npm and node #6812

Closed
jdl2206 opened this issue Aug 19, 2020 · 9 comments · Fixed by #6839
Closed

not compatible with latest version of npm and node #6812

jdl2206 opened this issue Aug 19, 2020 · 9 comments · Fixed by #6839

Comments

@jdl2206
Copy link

jdl2206 commented Aug 19, 2020

Description

It looks like it was updated 2 days ago but

errors when installing:
npm i video.js
npm WARN notsup Unsupported engine for pkcs7@1.0.2: wanted: {"npm":"^1.4.6","node":"^0.10"} (current: {"node":"12.16.3","npm":"6.14.8"})
npm WARN notsup Not compatible with your version of node/npm: pkcs7@1.0.2

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. Update to the latest version of npm and node
    2.install this plugin

Results

Expected

Please describe what you expected to see.

Actual

Please describe what actually happened.

Error output

If there are any errors at all, please include them here.

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

what version of videojs does this occur with?

browsers

what browser are affected?

OSes

what platforms (operating systems and devices) are affected?

plugins

are any videojs plugins being used on the page? If so, please list them below.

@welcome
Copy link

welcome bot commented Aug 19, 2020

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@gkatsev
Copy link
Member

gkatsev commented Aug 19, 2020

While it's something we should update, it is a warning you can ignore. It shouldn't affect anything.

@Jegp
Copy link

Jegp commented Aug 25, 2020

A more severe variant of this is a complete failure to build videojs on the newest node:slim docker. To reproduce

  1. docker run -it node:slim bash
  2. apt update && apt install git -y
  3. git clone https://github.com/videojs/video.js.git
  4. npm install && npm run build

This runs fine on node v12.18

@rtrigoso
Copy link

rtrigoso commented Sep 9, 2020

This is not a warning on 13.8.0

npm ERR! code ENOTSUP
npm ERR! notsup Unsupported engine for pkcs7@1.0.2: wanted: {"npm":"^1.4.6","node":"^0.10"} (current: {"node":"13.8.0","npm":"6.13.7"})
npm ERR! notsup Not compatible with your version of node/npm: pkcs7@1.0.2
npm ERR! notsup Not compatible with your version of node/npm: pkcs7@1.0.2
npm ERR! notsup Required: {"npm":"^1.4.6","node":"^0.10"}
npm ERR! notsup Actual:   {"npm":"6.13.7","node":"13.8.0"}

@delanni
Copy link

delanni commented Sep 9, 2020

It's as easy as releasing v1.0.3 from pkcs7... the code is there, the version is tagged, but I don't know why it's not released on NPM.

@gkatsev
Copy link
Member

gkatsev commented Sep 9, 2020

I'm looking into it. Basically, we never bothered because it's always been just a warning, if it's failing on node 13, definitely needs an update.

@gkatsev
Copy link
Member

gkatsev commented Sep 9, 2020

Merged update into VHS main videojs/http-streaming#947.
Will be out soon against 1.x videojs/http-streaming#946 which will come into Video.js shortly there-after.

@gkatsev
Copy link
Member

gkatsev commented Sep 10, 2020

The fix is now available in the 7.9.5 pre-release.

@delanni
Copy link

delanni commented Sep 10, 2020

Guys, you're awesome! Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
edirub pushed a commit to edirub/video.js that referenced this issue Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants