Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to access controls when 'full window' on iPad #7

Closed
amasses opened this issue Jun 1, 2010 · 4 comments
Closed

Unable to access controls when 'full window' on iPad #7

amasses opened this issue Jun 1, 2010 · 4 comments

Comments

@amasses
Copy link

amasses commented Jun 1, 2010

When testing the videojs player on an iPad, and pressing the 'full screen' button the controls are not accessible and the only way to control the video is to 'zoom' the video using the reverse-pinch gesture, and then accessing the native iOS video controls.

Given this I would suggest that this could be fixed by either hiding the full-window button when on an iOS device (users can use the reverse-pinch gesture to go full display-sized without this) or listen for the touch events to hide/show the video controls.

@heff
Copy link
Member

heff commented Jun 11, 2010

Thanks. Getting an iPad today. Hopefully I'll have this fixed soon.

@amasses
Copy link
Author

amasses commented Jun 12, 2010

I had an attempt at fixing this, by attaching an event listener to the touchstart, touchend and even the click events, putting a wrapper container around the video container to handle the touch events etc, however no such luck (and to be honest I'm not aware if its possible to simulate the touch event on the desktop...)

I'll be interested to see how this is tackled - I had a glance at the Vimeo code because they do it well, but haven't been able to succeed. :(

@heff
Copy link
Member

heff commented Jun 13, 2010

Got it working. It looks like the video was covering the controls. Try the one on the homepage and let me know how it goes.

@amasses
Copy link
Author

amasses commented Jun 13, 2010

Controls are coming up now, great work - thanks!

gkatsev added a commit to dmlap/video.js that referenced this issue Dec 31, 2014
Merge IE9 and master into captions branch.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants