Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't set volume when using iPhone without full screen #7040

Closed
Hsueh-Jen opened this issue Jan 14, 2021 · 6 comments · Fixed by #7514
Closed

Can't set volume when using iPhone without full screen #7040

Hsueh-Jen opened this issue Jan 14, 2021 · 6 comments · Fixed by #7514

Comments

@Hsueh-Jen
Copy link

Description

When I use iPhone to watch videojs player on all browsers like chrome, safari, etc. I can set volume when player is full screen, but I can't set volume when player is NOT full screen. I can't drag and drop the dot on volume bar to set volume. It always stay at default volume. Android phone can set volume smoothly. Whether it is full screen or not full screen

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. use iPhone and go to videojs official demo: https://videojs.com/advanced/?video=disneys-oceans
  2. try to set volume, and you can't set volume.
@welcome
Copy link

welcome bot commented Jan 14, 2021

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@mister-ben
Copy link
Contributor

It's normal that you can't set the volume on iOS Safari other than with the physical volume buttons. The volume control shouldn't be showing at all, there should just be the mute toggle, but apparently the check we make to see if setting the volume doesn't work now on latest iOS - the volume getter will briefly return the value it was set to.

@gkatsev
Copy link
Member

gkatsev commented Jan 14, 2021

the volume getter will briefly return the value it was set to.

oh no. I guess we'll want to do a workaround for it.

@klemensz
Copy link

I ran into the same issue now. Is there a workaround already?

@tania-shevtsova-gl
Copy link

hey @gkatsev i have the same issue when using mobile/tablets. is there any way to fix that? thanks in advance.

gkatsev added a commit that referenced this issue Nov 12, 2021
@gkatsev
fix: try again on volume feature detection on iOS
0f8fa0e 
On latest iOS, we are seeing times when the volume feature detection is
showing that we are able to change the volume, though, that is not the
case. Instead, on iOS, when we detect that we can control the volume, we
set a short timer to retest and reset the the featuresVolumeControl
property.

Fixes #7040
@gkatsev gkatsev mentioned this issue Nov 12, 2021
Merged
@gkatsev
Copy link
Member

gkatsev commented Nov 12, 2021

I have a proposed solution here #7514

gkatsev added a commit that referenced this issue Nov 17, 2021
@gkatsev
fix: try again on volume feature detection on iOS (#7514)
1d96d1c 
On latest iOS, we are seeing times when the volume feature detection is
showing that we are able to change the volume, though, that is not the
case. Instead, on iOS, when we detect that we can control the volume, we
set a short timer to retest and reset the featuresVolumeControl property.

Fixes #7040
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
edirub pushed a commit to edirub/video.js that referenced this issue Jun 8, 2023
@gkatsev @edirub
fix: try again on volume feature detection on iOS (videojs#7514)
d9dc117 
On latest iOS, we are seeing times when the volume feature detection is
showing that we are able to change the volume, though, that is not the
case. Instead, on iOS, when we detect that we can control the volume, we
set a short timer to retest and reset the featuresVolumeControl property.

Fixes videojs#7040
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: try again on volume feature detection on iOS videojs/video.js
5 participants
@gkatsev @klemensz @mister-ben @Hsueh-Jen @tania-shevtsova-gl