Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Guard against Safari adding native controls after fullscreen #7634

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

mister-ben
Copy link
Contributor

Description

Sometimes iOS Safari enabled native controls on the video el when existing fullscreen, resulting in both the native controls and Video.js controls being visible. Fixes #3762

Specific Changes proposed

  • Set controls to false on the tech el when iOS exits fullscreen, as long as nativeControlsForTouch is not being used.
  • Not pertinent to the double controls issue, but also fixes the behaviour of the vjs-ios-native-fs, which is currently toggling when entering fullscreen and remaining as is on exiting fullscreen. (Although this class may be able to be removed altogether if it wasn't being applied as intended anyway).

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, Safari)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #7634 (13043fc) into main (eeda26f) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7634      +/-   ##
==========================================
+ Coverage   80.24%   80.48%   +0.24%     
==========================================
  Files         116      116              
  Lines        7325     7328       +3     
  Branches     1771     1771              
==========================================
+ Hits         5878     5898      +20     
+ Misses       1447     1430      -17     
Impacted Files Coverage Δ
src/js/player.js 87.95% <100.00%> (+0.01%) ⬆️
src/js/tech/html5.js 67.02% <100.00%> (+3.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeda26f...13043fc. Read the comment docs.

@gkatsev gkatsev changed the title fix: Guard against Safari adding native controls after fiullscreen fix: Guard against Safari adding native controls after fullscreen Feb 4, 2022
@storyguy88
Copy link

Hey @mister-ben , is this merge-able? We'd love to use it asap. Thanks!

@misteroneill misteroneill added the patch This PR can be added to a patch release. label Feb 22, 2022
@misteroneill misteroneill merged commit f16d73b into videojs:main Feb 23, 2022
@storyguy88
Copy link

Thank you @mister-ben and @misteroneill !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iPhone displays double controls
4 participants