Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Captions Settings menu buttons don't work on mobile. #8808

Closed
rn4j1m1 opened this issue Jul 21, 2024 · 4 comments · Fixed by #8809 · 4 remaining pull requests
Closed

Captions Settings menu buttons don't work on mobile. #8808

rn4j1m1 opened this issue Jul 21, 2024 · 4 comments · Fixed by #8809 · 4 remaining pull requests

Comments

@rn4j1m1
Copy link

rn4j1m1 commented Jul 21, 2024

Description

Hi
Captions Settings menu Buttons (reset and done) don't work on mobile.

Reduced test case

https://v8-16-1--videojs-preview.netlify.app/

Steps to reproduce

I test With chrome on android phone

Errors

No response

What version of Video.js are you using?

8.16.1

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

Chrome 126

What OS(es) and version(s) does this occur with?

Android 11
@rn4j1m1 rn4j1m1 added the needs: triage This issue needs to be reviewed label Jul 21, 2024
@welcome Welcome
Copy link

welcome bot commented Jul 21, 2024

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@rn4j1m1
Copy link
Author

rn4j1m1 commented Jul 21, 2024

image

@mister-ben mister-ben mentioned this issue Jul 21, 2024
Merged
9 tasks
@mister-ben mister-ben removed the needs: triage This issue needs to be reviewed label Jul 21, 2024
@rn4j1m1
Copy link
Author

rn4j1m1 commented Jul 22, 2024

thanks
This issue has been solved by :
#8809

@rn4j1m1 rn4j1m1 closed this as completed Jul 22, 2024
@mister-ben
Copy link
Contributor

Thanks for reporting!

mister-ben added a commit that referenced this issue Jul 22, 2024
@mister-ben
fix: Listen to taps on track controls (#8809)
86d29cd 
## Description
The refactored text track controls aren't listening for tap events.

## Specific Changes proposed
Add tap handler to done and reset buttons.
Fixes #8808

## Requirements Checklist
- [x] Feature implemented / Bug fixed
- [ ] If necessary, more likely in a feature request than a bug fix
- [x] Change has been verified in an actual browser (Chrome, Firefox,
IE)
  - [ ] Unit Tests updated or fixed
  - [ ] Docs/guides updated
- [ ] Example created ([starter template on
JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
- [x] Has no DOM changes which impact accessiblilty or trigger warnings
(e.g. Chrome issues tab)
  - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
- [ ] Reviewed by Two Core Contributors
@kerasus kerasus mentioned this issue Aug 28, 2024
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mister-ben @rn4j1m1