Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Slider Not Working #942

Closed
nmatthew123 opened this issue Jan 15, 2014 · 13 comments
Closed

Vertical Slider Not Working #942

nmatthew123 opened this issue Jan 15, 2014 · 13 comments
Labels

Comments

@nmatthew123
Copy link

I am trying to make my volumeBar vertical by using this code posted here : #477
This is how I am setting up my video player

var myPlayer = videojs("video-player", {
    'children': {
      'controlBar': {
        'children': {
          'volumeControl': {
            'children': {
              'volumeBar' : {
                vertical: true
              }
            }
          }
        }
      }
    }
});

For some reason my video menu bar disappers. Do you have any idea what is going on? I've been working on this for a day and Im not sure what I should do. I haven't worked with videojs before so I'm a complete noob.

@heff
Copy link
Member

heff commented Jan 21, 2014

Did you figure this out?

@nmatthew123
Copy link
Author

No I have not gotten this to work.

@nmatthew123 nmatthew123 reopened this Jan 21, 2014
@heff heff added bug and removed bug labels Mar 4, 2014
@heff
Copy link
Member

heff commented Mar 4, 2014

You would actually need to enable the volumeMenuButton, and disable the volume control.
https://github.com/videojs/video.js/blob/v4.4.2/src/js/control-bar/control-bar.js#L23
They work pretty differently. You may have to add styles as well to make it look right. I don't know that it's fully implemented yet.

@heff heff closed this as completed Mar 4, 2014
@RushirajDYadav
Copy link

Any information about making video js volume bar control to make it vertical ??

@ksheurs
Copy link

ksheurs commented Nov 21, 2014

It seem enabling volumeMenuButton also enables volumeControl (even if explicitly is disabled). resulting in two volume controls. any ideas?

i'd like one volume control (menu based) and then transform rotate the volumeBar within that menu.

@mmcc
Copy link
Member

mmcc commented Nov 21, 2014

@ksheurs - I can't reproduce: example. Mind putting up a JSBin or something along those lines that shows the issue?

@ksheurs
Copy link

ksheurs commented Nov 21, 2014

oh man you're too fast :) was just coming back to reply with that i accidentally mixed up muteToggle and volumeControl. thank you!

is it possible to set the volumeBar within the menu to vertical, without re-enabling the main/default volume bar (not within the menu)? something like below..

'volumeBar' : {
   vertical: true
 }

@ksheurs
Copy link

ksheurs commented Nov 21, 2014

example i get http://cl.ly/image/363l3K2H1a1O with the following:

children: {
  controlBar: {
    children: {
      muteToggle: false,
      volumeControl: false,
      volumeMenuButton: {
      children: {
         volumeBar: {
           vertical: true
         }
       }
     }
   }
  }
}

@mmcc
Copy link
Member

mmcc commented Nov 21, 2014

This is a bit of a tricky one. You don't need to nest the volumeBar options under children within volumeMenuButton. You also need to add some styles to actually rotate the slider. Putting it all together :)

@ksheurs
Copy link

ksheurs commented Nov 21, 2014

very nice, thank you sir!

@mmcc
Copy link
Member

mmcc commented Nov 21, 2014

No prob! Apologies for the kinda wonky config block there...we're still working to clean that up. This is kinda one of those things that you can do but we don't necessarily want to officially document it yet (for reasons like this).

@whitecodewarrior
Copy link

Perfect solution, Thank you for sharing, mmcc !!!

@ghost
Copy link

ghost commented Aug 17, 2017

Evaluate new skin video-js-6.2.4

https://github.com/maluklo/Skin-video-js-6.2.4

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants