Vertical slider

[gkatsev]

• Change vjs.findPosX to vjs.findPosition to return both left and top.

This also removes the fallback method that doesn't use the getBoundingClientRect because according to MDN and PPK, it should be supported just about everywhere.

• Make sliders able to handle vertical sliders in calculateDistance.

This takes a 'vertical' option on the slider bar itself. If set, it will use the top and pageY values to calculate the slider positions.

For example, to make a vertical volume slider:

  var player = videojs(document.querySelector('.video-js'), {
    'children': {
      'controlBar': {
        'children': {
          'volumeControl': {
            'children': {
              'volumeBar' : {
                vertical: true
              }
            }
          }
        }
      }
    }
  });

[dmlap]

That's a whole lot o' config.

[heff]

Nice. Would you mind writing some tests for vjs.findPosition?

[gkatsev]

Good idea, I'll work on that tomorrow.
If you have any ideas of how to de-duplicate calculateDistance any further, I'm all ears.

[heff]

Very nice.

The new test needs to clean itself up, either by appending the div to the qunit fixture (which auto-empties) or by removing the div manually.

Pulling in anyway, but would be good to do a follow up on that.

[gkatsev]

Ah, right. I think we need to do that with another test that we wrote as well.