Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a sensible toJSON for a vjs object. #957

Closed
2 of 5 tasks
gkatsev opened this issue Jan 22, 2014 · 6 comments
Closed
2 of 5 tasks

Create a sensible toJSON for a vjs object. #957

gkatsev opened this issue Jan 22, 2014 · 6 comments

Comments

@gkatsev
Copy link
Member

gkatsev commented Jan 22, 2014

Would be nice if we were able to come up with a sensible output for a toJSON function so that when a user does JSON.stringify it doesn't throw on them.


Please describe the feature/enhancement (be as detailed as possible when describing the use cases behind it).

Any existing documentation/specs?
Any existing examples?

To finish

  • Tests written
  • Feature implemented
  • Docs/guides updated
  • Example created (e.g. jsbin)
  • Pull request submitted
@heff
Copy link
Member

heff commented Jan 22, 2014

Is there any other background we can provide around what use cases would cause someone to run into this issue?

The simplest option mentioned for this was to have it output a simple string like "video player".

@heff
Copy link
Member

heff commented Apr 28, 2015

@gkatsev this one isn't clear yet. Can you talk about what you want this to look like so another person could work on it? I think you originally just said to have it return a string with 'player' or something.

@EZWrighter
Copy link

Would be nice if you could serialize player state out with this. Sources, Tracks, poster, control states, current player head position. Not sure how useful it would be, but it makes sense intuitively.

@gkatsev
Copy link
Member Author

gkatsev commented Apr 28, 2015

Not sure exactly what I had in mind originally but last night when I noticed it, I thought of something like what @EZWrighter said.

@heff
Copy link
Member

heff commented Apr 28, 2015

That works for me. Could one of you give some specific definition around it and provide and example, so anyone could jump in and work on it?

gkatsev added a commit to gkatsev/video.js that referenced this issue May 1, 2015
@gkatsev gkatsev mentioned this issue May 1, 2015
gkatsev added a commit to gkatsev/video.js that referenced this issue May 1, 2015
@gkatsev
Copy link
Member Author

gkatsev commented May 1, 2015

Fixed via #2114

@gkatsev gkatsev closed this as completed May 1, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants