-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a sensible toJSON for a vjs object. #957
Comments
Is there any other background we can provide around what use cases would cause someone to run into this issue? The simplest option mentioned for this was to have it output a simple string like "video player". |
@gkatsev this one isn't clear yet. Can you talk about what you want this to look like so another person could work on it? I think you originally just said to have it return a string with 'player' or something. |
Would be nice if you could serialize player state out with this. Sources, Tracks, poster, control states, current player head position. Not sure how useful it would be, but it makes sense intuitively. |
Not sure exactly what I had in mind originally but last night when I noticed it, I thought of something like what @EZWrighter said. |
That works for me. Could one of you give some specific definition around it and provide and example, so anyone could jump in and work on it? |
Fixed via #2114 |
Would be nice if we were able to come up with a sensible output for a toJSON function so that when a user does
JSON.stringify
it doesn't throw on them.Please describe the feature/enhancement (be as detailed as possible when describing the use cases behind it).
Any existing documentation/specs?
Any existing examples?
To finish
The text was updated successfully, but these errors were encountered: