Added try/catch to protect against IE with no Media Player. Fixes #984 #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (typeof el.load === 'function') { | ||
| el.load(); | ||
| try { |
There was a problem hiding this comment.
Can we wrap this in a function to make sure that disposeMediaElement isn't deoptimized by js engines for having a try/catch?
There was a problem hiding this comment.
Um... either as just an IIFE or a whole separate function we call here. An IIFE is probably good.
if (typeof el.load === 'function') {
(function() {
try {
el.load();
} catch (e) {
// not supported
}
})();
}There was a problem hiding this comment.
Ah, yeah, I was thinking about the isSupported one. And I'm guessing it's not worth doing the same there, yeah?
I'll add this in. What would the negative affects be of deoptimization? Just slower processing?
There was a problem hiding this comment.
De-optimized code runs in the js interpreter so it's significantly slower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.