Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monkeypatch canPlayType on Android 4.0+ for HLS #1084

Merged
merged 14 commits into from
Mar 26, 2014
Merged

Monkeypatch canPlayType on Android 4.0+ for HLS #1084

merged 14 commits into from
Mar 26, 2014

Commits on Mar 13, 2014

  1. Monkeypatch canPlayType on Android 4.0+ for HLS 

    Android devices starting with 4.0 can play HLS natively to some extent.
However, they do not say so in the canPlayType method. This commit
monkey patches canPlayType to respond with "maybe" for
"application/x-mpegURL" and "application/vnd.apple.mpegURL". Otherwise,
it'll fallback to the original canPlayType method.
    @gkatsev
    gkatsev committed Mar 13, 2014
    Configuration menu
    Copy the full SHA
    e35083b View commit details
    Browse the repository at this point in the history

  2. be case insensitive

    @gkatsev
    gkatsev committed Mar 13, 2014
    Configuration menu
    Copy the full SHA
    252ad3f View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2014

  1. + vjs.Html5.{patchCanPlayType,unpatchCanPlayType} 

    patchCanPlayType is called on load.
It patched video#canPlayType if needed.
unpatchCanPlayType will revert the patch and return the patch function.
There are also corresponding tests that test patchCanPlayType,
unpatchCanPlayType and also whether the patch functions themselves work
correctly.
    @gkatsev
    gkatsev committed Mar 18, 2014
    5 Configuration menu
    Copy the full SHA
    5381f70 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2014

  1. fix up jshint errors

    @gkatsev
    gkatsev committed Mar 24, 2014
    Configuration menu
    Copy the full SHA
    86c3f94 View commit details
    Browse the repository at this point in the history

  2. Switch HTMLVideoElement to constructor reference

    @gkatsev
    gkatsev committed Mar 24, 2014
    Configuration menu
    Copy the full SHA
    f86e073 View commit details
    Browse the repository at this point in the history

  3. Also, switch out HTMLVideoElement to constructor reference in tests

    @gkatsev
    gkatsev committed Mar 24, 2014
    Configuration menu
    Copy the full SHA
    817253b View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2014

  1. call unpatchCanPlayType after tests

    @gkatsev
    gkatsev committed Mar 25, 2014
    Configuration menu
    Copy the full SHA
    0c856ce View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2014

  1. Don't assume only mimetype available for matching

    @gkatsev
    gkatsev committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    f1d2aef View commit details
    Browse the repository at this point in the history

  2. remove unused var

    @gkatsev
    gkatsev committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    fef6282 View commit details
    Browse the repository at this point in the history

  3. return the patched function from unpatchCanPlayType

    @gkatsev
    gkatsev committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    75bd76f View commit details
    Browse the repository at this point in the history

  4. update for IE8 and fixup stupid tests

    @gkatsev
    gkatsev committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    94ec725 View commit details
    Browse the repository at this point in the history

  5. add existence test for patch and unpatch methods

    @gkatsev
    gkatsev committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    d21019a View commit details
    Browse the repository at this point in the history

  6. fix typo for unpatchCanPlayType

    @gkatsev
    gkatsev committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    e2a1cac View commit details
    Browse the repository at this point in the history

  7. Always unpatch canPlayType. 

    Fix up tests to not ignore some if canPlayType is not available since
unpatch is no longer broken.
    @gkatsev
    gkatsev committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    e39557e View commit details
    Browse the repository at this point in the history