Fixed component.trigger doesn't pass event object issue #1298 #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
| * | ||
| * @param {String} type The event type to trigger, e.g. 'click' | ||
| * @param {Event|Object} event The event object to be passed to the listener | ||
| * @param {Object} event either a string (the event type) |
There was a problem hiding this comment.
The jsdoc type here would be {Event|Object|String}
| * @param {Element|Object} elem Element to trigger an event on | ||
| * @param {String} event Type of event to trigger | ||
| * @param {Element|Object} elem Element to trigger an event on | ||
| * @param {Event|Object|String} event either a string (the event type) |
There was a problem hiding this comment.
FYI, I had to change these comments to be single-line otherwise the docs parser wasn't picking up anything but the first line
|
Thank you! If you're on IRC check out the #videojs room and chat with other contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.