add a hasClass() method #1464
Closed
add a hasClass() method #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two goals here: First, the removeClass() wasn't adding spaces before and after element.className and the class. This could create weird false positives as we get into compound class names, like vjs-fluid, and vjs-fluid-4-3. This aligns the check across both methods. Second, I think hasClass is going to be essential for testing, going forward.
| @@ -314,18 +328,19 @@ vjs.addClass = function(element, classToAdd){ | |||
| vjs.removeClass = function(element, classToRemove){ | |||
| var classNames, i; | |||
|
|
|||
| if (element.className.indexOf(classToRemove) == -1) { return; } | |||
| if (vjs.hasClass(element, classToRemove)) { | |||
There was a problem hiding this comment.
if you make this if check !hasClass, and then return, it will keep the rest of this function not indented, which is nice.
|
Other than the two comments, LGTM. |
|
Yeah, this looks good to me, thanks! If you want to make the updates @gkatsev mentioned, and add a quick test this should be ready to go. |
| * @return {vjs.Component} | ||
| */ | ||
| vjs.Component.prototype.hasClass = function(classToCheck){ | ||
| vjs.hasClass(this.el_, classToCheck); |
There was a problem hiding this comment.
Actually this should return the result of vjs.hasClass.
I think I'm there now. Thx for your patience!
|
I could also rewrite some of the older tests to use hasClass(), too. The older tests incorrectly match a substring, e.g. https://github.com/videojs/video.js/blob/master/test/unit/component.js#L184 but I think this works now as is. |
|
Good to go for this week's release. |
|
Merged in. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two goals here:
First, the removeClass() wasn't adding spaces before and after element.className and the class. This could create weird false positives as we get into compound class names, like vjs-fluid, and vjs-fluid-4-3. This aligns the check across both methods.
Second, I think hasClass is going to be essential for testing, going forward.