Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On ended, pause player if not paused or looping #1507

Closed
wants to merge 3 commits into from
Closed

On ended, pause player if not paused or looping #1507

wants to merge 3 commits into from

Commits on Sep 16, 2014

  1. On ended, pause player if not paused or looping 

    IE11 (and maybe other browsers as well) only fire 'ended' event when the
video ends and doesn't fire pause. This makes IE11 not reset it's state
into a paused state that allows a user to replay immediately. However, a
two clicks on the play/pause button will allow you to replay.
In Chrome, we get first a pause event and then an ended event. When
'loop' is set, neither the last pause nor ended fire.
In the flash tech, the pause and ended events fire like in chrome in all
browsers.
    @gkatsev
    gkatsev committed Sep 16, 2014
    Configuration menu
    Copy the full SHA
    7322b20 View commit details
    Browse the repository at this point in the history

  2. Add tests for onEnded change

    @gkatsev
    gkatsev committed Sep 16, 2014
    Configuration menu
    Copy the full SHA
    9b935b1 View commit details
    Browse the repository at this point in the history

  3. Appease jshint.

    @gkatsev
    gkatsev committed Sep 16, 2014
    Configuration menu
    Copy the full SHA
    e8ffd13 View commit details
    Browse the repository at this point in the history