Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ru.json #1563

Closed
wants to merge 1 commit into from
Closed

Create ru.json #1563

wants to merge 1 commit into from

Conversation

OlegTsvirko
Copy link
Contributor

Hello. I have just created a Ukrainian and Russian translations for video.js, but I don't understand how to use them? Where should I see all of this words? Is there any example exist? Because when I use videojs player or watch demo on http://www.videojs.com/ I didn't see any words or sentences there. Thanks.

@gkatsev
Copy link
Member

gkatsev commented Oct 3, 2014

You need to create your own build of videojs that includes these files. Then you can tell videojs the language of your player: https://github.com/videojs/video.js/blob/master/docs/guides/languages.md#setting-default-language-in-a-videojs-player

@OlegTsvirko
Copy link
Contributor Author

Thanks for response. I actually do all exactly as mentioned on this page. But I don't see any changes at all. Where should it be? The text should appear when I place mouse cursor over the elements or what?

@gkatsev
Copy link
Member

gkatsev commented Oct 3, 2014

If you inspect the player controls, (e.g., play button), there should be the text visible. The text in the control bar is mostly for screen readers. Also, errors that are visible should display in the specified language. You could try triggereing an error by calling player.error({code: 0}); or codes 0 through 4.

@OlegTsvirko
Copy link
Contributor Author

Well, when I use wrong src="" Chrome show me translated error, but Firefox does not (only spinning icon). And there are no any text on player controls at all.

@mmcc
Copy link
Member

mmcc commented Oct 3, 2014

You're better off actually triggering the error from the console as @gkatsev suggested. Re: The player control text, you need to actually inspect the elements to see the text (via the developer tools for your browser).

@gkatsev
Copy link
Member

gkatsev commented Oct 3, 2014

It not showing up in firefox may be a bug.

@OlegTsvirko
Copy link
Contributor Author

222
In other hand when I use player.error({code: 0}); I see the result only in Firefox, but not in Chrome (correction: in chrome I see cross for one second). Screenshot to my previous comment.

And I think the inscription 'subtitles off' also had to be translated, but it is not

@mmcc
Copy link
Member

mmcc commented Oct 3, 2014

Yep, had me confused with the original comment. The error seems to fire in Firefox and not in Chrome, (but, fwiw, the error always fires if Flash is used).

Here's a JSBin, but for some reason FF only gives an error code if you load it in the side by side output. Loading the standalone preview, however, just gives an eternal spinning error. 💢

@OlegTsvirko
Copy link
Contributor Author

On JSBin I see spinning icon in Chrome and error text with cross in FF

@mmcc
Copy link
Member

mmcc commented Oct 3, 2014

Yep, I see it in edit mode, but not in the standalone preview, which is odd.

Regardless, we're getting pretty off track from translations here. If this is a confirmed issue (which it appears to be), we should open up a new issue for tracking. Maybe just see if we should reopen #869?

@OlegTsvirko
Copy link
Contributor Author

Good that in the course of solving my question we discovered an old problem. Thanks to all of you guys. And dont forget to add this translations into project :)

@mmcc
Copy link
Member

mmcc commented Oct 3, 2014

Thanks for the help! I went ahead and reopened #869.

@heff
Copy link
Member

heff commented Oct 6, 2014

Merged in, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants