Normalize IE9 URL parsing. Fix for #1764 #1765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE9 appends the port number to the host property of anchor tags on http pages. Strip the port for http and https so that it behaves like everyone else.
| var createElement; | ||
|
|
||
| module('Lib', { | ||
| setup: function() { |
There was a problem hiding this comment.
I think you need quotes around setup/teardown.
|
Something is breaking tests. Might be the note I made. |
Make sure `setup` and `teardown` don't get minified so that the lib tests don't pollute the global environment.
|
@heff locally, looks like you were right about the quoting. |
|
lgtm; Did you test this on a page that uses a local server with a different port? |
|
Yes, that's how I normally do my testing. Getting things setup so I could test on port 80 ended up being the complicated bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE9 appends the port number to the host property of anchor tags on http pages. Strip the port for http and https so that it behaves like everyone else.