Extended canHandleSource in media files to consistently guess mime types. Fixes #1833 #1974
Conversation
…es to consistently guess mime types. Fixes #1833
|
Awesome, thanks! |
| var pathParts; | ||
|
|
||
| if(typeof path === 'string'){ | ||
| splitPathRe = /^(\/?)([\s\S]*?)((?:\.{1,2}|[^\/]+?)(\.([^\.\/\?]+)))(?:[\/]*|[\?].*)$/i; |
There was a problem hiding this comment.
That's a pretty advanced regex. What does it add over the one that was in the html5 tech?
There was a problem hiding this comment.
It's the regex from iojs, which we talked about in the other pr comments
|
Added a few comments, but otherwise this looks good to me. 👍 |
|
I think this is ready to go. Just need one more person to review and sign off on it. @videojs/core-committers |
|
Sent from Windows Mail From: Steve Heffernan Added a few comments, but otherwise this looks good to me. 👍 — |
|
@xy2015 I can not see you comments can you please add them again or point me to them?? |
|
LGTM |
Extended canHandleSource in media files to consistently guess mime types. Fixes #1833
|
@heff I hit the "merge" button by habit, sorry. I'll fix up the changelog tomorrow morning |
|
No problem. Though @mmcc might not have fun rebasing the ES6 work again. 😄 |
|
(╯°□°）╯︵ ┻━┻ — On Wed, Apr 1, 2015 at 9:30 PM, Steve Heffernan notifications@github.com
|
|
@mmcc sorry! |
Add entry for videojs#1974.
|
Ok this is now pulled into ES6 branch, but I'm going to hold off on pushes until all the comments are addressed. I've rebased from master to clean up the commit history so I think we'll lose all the comments when I end up force pushing. |
Added getFileExtension to libs. And used it on Html5 and Flash canHandleSource method to guess the mime type if necessary.