Throw an error if techOrder isn't in options. For #1998 #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bail with a friendly error if techOrder isn't defined during player construction. Add in a qunit test page at the root of the tests directory for simpler browser debugging.
| </head> | ||
| <body> | ||
| <div id="qunit"></div> | ||
| <div id="qunit-fixture"></div> |
There was a problem hiding this comment.
If the globals-shim is used with this html, we should probably delete this fixture because it will be duplicated by the shim.
|
FYI: the build failure is a coveralls thing. Everything else passed. |
Coveralls is behaving unreliably so treat a failure as a warning.
The test fixture is created in the globals shim now so remove the inline element. Add the default video.js styles to the page until we turn on the script-based injection.
|
Lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bail with a friendly error if techOrder isn't defined during player construction. Add in a qunit test page at the root of the tests directory for simpler browser debugging.