Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose videojs.plugin() #2103

Closed
wants to merge 2 commits into from
Closed

Expose videojs.plugin() #2103

wants to merge 2 commits into from

Conversation

dconnolly
Copy link
Contributor

So that plugins can be registered with the same api! Also a unit test
module for the video.js entrypoint.

Fixes #2102

@dconnolly
Expose videojs.plugin()
e445006 
So that plugins can be registered with the same api!  Also a unit test
module for the video.js entrypoint.

Fixes videojs#2102
@gkatsev
Copy link
Member

gkatsev commented Apr 30, 2015

LGTM

@heff
Copy link
Member

heff commented Apr 30, 2015

Very nice.

@heff heff closed this in f84632e Apr 30, 2015
@dconnolly dconnolly deleted the feature/expose-plugin branch April 30, 2015 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
confirmed enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5.0.0-1 does not expose plugin() on videojs object.
3 participants
@dconnolly @gkatsev @heff