Component styles #2105

gkatsev · 2015-04-30T23:53:28Z

component.js will now pass latest version of videojs-standard.
There are still a few warning that it issues, though. These will not fail the build.

standard: Use VideoJS JavaScript Standard Style (https://github.com/videojs/standard)
/Users/gkatsevman/p/video.js/src/js/component.js:206:0: Line 206 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:309:0: Line 309 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:310:0: Line 310 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:311:0: Line 311 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:321:0: Line 321 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:328:0: Line 328 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:457:36: Unexpected use of undefined.
/Users/gkatsevman/p/video.js/src/js/component.js:677:0: Line 677 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:725:0: Line 725 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:861:0: Line 861 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:871:16: Unexpected use of undefined.
/Users/gkatsevman/p/video.js/src/js/component.js:873:26: Comparing to itself is potentially pointless.
/Users/gkatsevman/p/video.js/src/js/component.js:886:0: Line 886 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:912:4: Unexpected todo comment.
/Users/gkatsevman/p/video.js/src/js/component.js:945:0: Line 945 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:985:4: Unexpected todo comment.
/Users/gkatsevman/p/video.js/src/js/component.js:1075:0: Line 1075 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:1160:0: Line 1160 exceeds the maximum line length of 90.
/Users/gkatsevman/p/video.js/src/js/component.js:1170:0: Line 1170 exceeds the maximum line length of 90.

gkatsev · 2015-04-30T23:54:48Z

src/js/component.js


    // The component might be the player itself and we can't pass `this` to super
    if (!player && this.play) {
-      this.player_ = player = this;
+      this.player_ = player = this; // eslint-disable-line


This is how you would ignore a single line if we really want to keep it and it breaks the rules.
I decided to do it for this line because it's too much of a pain to figure out a good way to refactor this so what is happening is still clear.

heff · 2015-05-01T00:37:01Z

LGTM!

This now passes the style linting as followed by videojs-standard. There are still some warnings but no errors.

gkatsev reviewed Apr 30, 2015
View reviewed changes

heff added enhancement confirmed labels May 1, 2015

Add videojs-standard ignores

5a5827f

gkatsev force-pushed the component-styles branch from 64cb362 to 5af5013 Compare May 1, 2015 19:38

Update styles to conform to videojs-standard.

cced242

This now passes the style linting as followed by videojs-standard. There are still some warnings but no errors.

gkatsev force-pushed the component-styles branch from 5af5013 to cced242 Compare May 1, 2015 19:38

gkatsev closed this in 43a1429 May 1, 2015

gkatsev deleted the component-styles branch August 12, 2015 18:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Component styles #2105

Component styles #2105

gkatsev commented Apr 30, 2015

gkatsev Apr 30, 2015

heff commented May 1, 2015

Component styles #2105

Component styles #2105

Conversation

gkatsev commented Apr 30, 2015

gkatsev Apr 30, 2015

Choose a reason for hiding this comment

heff commented May 1, 2015