Adding back caption-settings styles. Closes #2104 #2107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcc
force-pushed
the
add-back-captions-settings-styles
branch
from
b902c5b to
3eea58d
Compare
mmcc
force-pushed
the
add-back-captions-settings-styles
branch
from
3eea58d to
dce4d40
Compare
|
dat stack trace. |
|
ping |
|
I figured out why the errors failed. It's because when we switched to concise methods, our new method shadowed the global |
|
@gkatsev sweet |
|
These styles look great. |
|
I'll have a PR against this PR after lunch. |
|
@mmcc can you merge master to fix the tests? |
|
Closing this in favor of #2112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.