-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Sauce Labs browsers #2149
Conversation
Awesome, thanks Joe. If we just left off the device and platform versions, would it use the latest ones? It'd be nice to not have to manually update this as versions increase. |
I simplified the browser capabilities some more, right now IE will default to Win7 - IE11 and Android will default to latest. Only iOS and Safari need versions or else they will default to iOS 5 and Safari for Windows. I'm also not able to get the iOS and Android tests to run so I am skipping them for now. |
Nice, thanks.
😠
😞 Yeah I saw Android pass once but Bootstrap skips them all together because the platform is flaky. I couldn't get iOS to run either. We should test on read devices to make sure there isn't a problem there. |
I bumped up the timeouts from 1min to 5 and got the Android tests to pass. The iOS tests at least start but seem to hang half way through. When I view the qunit page in the simulators/emulators on Sauce Labs they pass. Also just checked on real devices and they pass too. |
The automated Sauce Labs test's screencast should give some indication of which individual testcase it's getting hung up on. |
Instead of dealing with karma being weird I decided to swap in grunt-saucelabs. The iOS and Android tests pass now but IE and Firefox on Linux are timing out. I'll see if I can figure out the issues. |
I just got an email that Sauce Connect 3 is being EOL'd for Connect 4. Are we already using 4? Also I really hope their logo now includes this some how... |
Any guesses on if that will help with some of the issues we've seen? |
IE seems to be working now, I don't know if it is related to SC 4 though. Firefox on any platform refuses to work, I'll leave that for a future fix. |
@@ -9,7 +9,33 @@ | |||
<body> | |||
<div id="qunit"></div> | |||
<script src="../node_modules/qunitjs/qunit/qunit.js"></script> | |||
|
|||
<script type="text/javascript"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do exactly?
(Also, technically, the type
isn't necessary in scripts anymore :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows you to see the test results in Sauce Labs.
https://saucelabs.com/tests/68dcb9204fb94091996679fa2299f054
Should I just put this in globals-shim.js?
LGTM |
Slightly tangential, but you might want to consider switching from Sauce Labs to a different Selenium provider. See theintern/intern#394 |
I also found Browserstack to be more stable. HLS videos seem to not work in Sauce Labs OS X but work fine in Browserstack so it might be something to look into. |
How complicated would the switch be for us? @cvrebert have you tried out intern? Is that something we should look into using? |
I have not used intern personally, although it sounds promising. |
This change is to: