Clean up and documentation of src/js/video.js and DOM functions #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +68,7 @@ export const insertFirst = function(child, parent){ | |||
| * @type {Object} | |||
| * @private | |||
| */ | |||
| export const cache = {}; | |||
| const _data = {}; | |||
There was a problem hiding this comment.
since this isn't exported, there's no need for the _.
There was a problem hiding this comment.
Cool. Is that the common practice? Add an underscore only to private vars that are going to be accessible externally?
|
other than the |
| Options['languages'][code] = data; | ||
| } | ||
| return Options['languages']; | ||
| return merge(globalOptions.languages, { [code]: data })[code]; |
Preparing to export utility functions on the videojs object closes videojs#2182 Change el() to getEl() for consistency Cleaned up DOM functions library Clean up and document videojs object API Fixed mergeOptions to modify the first object instead of a copy More cleanup of the main video.js file and documentation Fixed issues with mergeOptions Cleaned up the addLanguage function Removed unnecessary underscores in private module vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
videojsobject.