Add the vjs-big-play-centered class back #2293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcc
force-pushed
the
add-big-play-centered-back
branch
from
1b15a31
to
c37f951
Compare
|
Looks good to me. Also to note, this switches the control bar variables to use the double-dash style for properties. I believe @mmcc said that's a standard sass style. |
|
Reference. I've seen it in a few other places, but over time I've started following more and more of what's outlined in that post, so at this point I'm almost willing to say we should just wholesale adopt it. |
|
I haven't read all of that but don't have any immediate objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.