Fix inactivityTimeout declaration. Fixes #2298. #2299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Looks good to me. |
|
lgtm Thanks for trying out contrib. We need to fix the contributing guide and that process. |
|
Merged in, thanks! What error did you see with contrib feature submit? |
|
I did few steps wrong at first (e.g. I didn't checkout the feature branch). However in the end everything works... just the pull request was not created. I get no error from |
|
@heff It is already reported as contrib/contrib#22 . |
|
Ah, got it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason
contrib feature submit(as described in CONTRIBUTING.md) did not work so I am submitting this manually via GitHub web.