Enable simple class extensions without any constructor #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelhoral
force-pushed
the
feature/implicit-super-constructor-call
branch
from
c17b94e
to
cb1e4ab
Compare
`videojs.extends` now properly handles the case when there is no constructor provided for the child class. Fixes videojs#2303.
pavelhoral
force-pushed
the
feature/implicit-super-constructor-call
branch
from
cb1e4ab
to
a9964d0
Compare
|
Looks good to me, thanks! And thanks for the test. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
videojs.extendsto properly handle creating a subclass without any specified constructor. Previous implementation just threw child properties/methods away. Fixes #2303.