Fix potential triggerReady infinite-loop #2398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the readyQueue_ is not reset before processing, a triggerReady later on in the call graph potentially results in an infinite loop
|
At first I was wondering if this would affect ready handlers that were added during the ready loop, but since we set isReady to true first it won't. LGTM |
|
@heff That nuance is precisely what threw me off when looking over vjs5's implementation! |
dmlap
pushed a commit
to dmlap/video.js
that referenced
this pull request
Jul 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
readyQueue_is not reset before processing, atriggerReadylater on in the call graph potentially results in an infinite loop.