Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "video" to "media" in error messages. #2409

Closed
wants to merge 2 commits into from
Closed

Change "video" to "media" in error messages. #2409

wants to merge 2 commits into from

Conversation

sirlancelot
Copy link
Contributor

Fixes #2407

@pam
Copy link

pam commented Jul 25, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 08ae1cd
Build details: https://travis-ci.org/pam/video.js/builds/72629754

(Please note that this is a fully automated comment.)

@sirlancelot
Copy link
Contributor Author

Looks like the failed test has nothing to do with this change in particular: Build Log Line 566

@gkatsev
Copy link
Member

gkatsev commented Jul 25, 2015

@pam retry

@gkatsev
Copy link
Member

gkatsev commented Jul 25, 2015

Yep, test failure is saucelabs being flaky

@pam
Copy link

pam commented Jul 25, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 08ae1cd
Build details: https://travis-ci.org/pam/video.js/builds/72633146

(Please note that this is a fully automated comment.)

@mister-ben
Copy link
Contributor

All of the files in lang would also need to be updated. They use the English error as keys.

@heff
Copy link
Member

heff commented Jul 26, 2015

We should probably just pull this in and let the translations come in as they can. We could go back and ping the original translators too.

@pam
Copy link

pam commented Jul 26, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 9eab598
Build details: https://travis-ci.org/pam/video.js/builds/72733512

(Please note that this is a fully automated comment.)

@dmlap
Copy link
Member

dmlap commented Jul 27, 2015

@heff I believe mister-ben is pointing out that the translations won't work at all because the English keys won't match. It makes sense to let the values get updated independently but are you sure we should pull this in without updating the keys in the translations?

@gkatsev
Copy link
Member

gkatsev commented Jul 27, 2015

All the keys were updated in the language files.

@sirlancelot
Copy link
Contributor Author

I updated the keys in 9eab598 as seen right above @pam's comment. Unfortunately, I don't speak the 25 languages to update their values ;)

@dmlap
Copy link
Member

dmlap commented Jul 30, 2015

Oops. That's what I get for trying to do a code review from my phone. Nevermind my comment. LGTM.

dmlap pushed a commit to dmlap/video.js that referenced this pull request Aug 3, 2015
@dmlap dmlap closed this in d3d1a7f Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants