-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "video" to "media" in error messages. #2409
Change "video" to "media" in error messages. #2409
Conversation
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 08ae1cd (Please note that this is a fully automated comment.) |
Looks like the failed test has nothing to do with this change in particular: Build Log Line 566 |
@pam retry |
Yep, test failure is saucelabs being flaky |
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 08ae1cd (Please note that this is a fully automated comment.) |
All of the files in lang would also need to be updated. They use the English error as keys. |
We should probably just pull this in and let the translations come in as they can. We could go back and ping the original translators too. |
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 9eab598 (Please note that this is a fully automated comment.) |
@heff I believe mister-ben is pointing out that the translations won't work at all because the English keys won't match. It makes sense to let the values get updated independently but are you sure we should pull this in without updating the keys in the translations? |
All the keys were updated in the language files. |
Oops. That's what I get for trying to do a code review from my phone. Nevermind my comment. LGTM. |
Fixes #2407