Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mutate the source #2418

Closed
wants to merge 3 commits into from
Closed

Don't mutate the source #2418

wants to merge 3 commits into from

Commits on Jul 31, 2015

  1. Don't mutate the source 

    mergeOptions did not mutate its first argument in video.js 4.x. Restore this behavior.
    @dmlap
    dmlap committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    3018fcf View commit details
    Browse the repository at this point in the history

  2. Remove extra import 

    isArray isn't used in this module.
    @dmlap
    dmlap committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    0d90544 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2015

  1. Setting global options should perform a mutating merge 

    The global options setter was returning a new object after mergeOptions() was converted to be non-mutating. Use lodash's merge() so that the setting changes persist. Add comments to mergeOptions().
    @dmlap
    dmlap committed Aug 4, 2015
    Configuration menu
    Copy the full SHA
    1ca358b View commit details
    Browse the repository at this point in the history