-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore formatTime #2420
Restore formatTime #2420
Conversation
lgtm |
@@ -397,6 +398,20 @@ videojs.log = log; | |||
videojs.createTimeRange = createTimeRange; | |||
|
|||
/** | |||
* @file format-time.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@file
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. copy/paste. The @file
isn't needed here, and could probably be moved into it's own comment block in format-time.js to avoid future issues like this.
Need to remove the |
|
Several core plugins use this method and there is at least one external plugin that uses it (found via GitHub issues).
15b3028
to
bd50a3a
Compare
seconded! |
👍 |
Several core plugins use this method and there is at least one external plugin that uses it (found via GitHub issues).